fix(neogit): improve Neogit colors

[mizlan]

before

after

[mizlan]

As an active Neogit user, I find the existing colors intolerable so I created this new set of highlights that takes advantage of ucolors.darken a lot!

[nullchilly]

Thank! I am still using vim-fugitive
I guess its time to try neogit out :)

[nullchilly]

@mizlan Don't you think it's still a bit hard to see the first line in NeogitCommitView?

[mizlan]

Also see this: NeogitOrg/neogit#330

Will work on this, will also probably PR Neogit to get customization on the other hunks (I want to dim unfocused hunk's context lines)

[mizlan]

Foreground also turns weird blue color in Commit view mode, will try to fix as well

[mizlan]

This is the best I can do for now, since I dont know why it's blue. Fixed formatting, and added some more hlgroups. Take a look:

[nullchilly]

@mizlan It's too dim for me though?

[mizlan]

Yeah, thats a bit of a problem. However, the goal is to fix that in Neogit itself so the hunk under cursor uses the other set of highlights. These, then, would be the "inactive" hunks. I think for now this is an alright approach.

[nullchilly]

@mizlan So we are missing the ActiveHunk

Why not just decrease the dim in the meantime and open another pr later when InactiveHunk is fixed?

[mizlan]

Good question. Maybe my workflow is different than others but I spend 99% of my time in the status buffer, where the dimmed text matters and is significantly helpful. I rarely view existing commits or browse diffs in other forms in Neogit. I cannot say the same for others' workflows but I'll be happy to change it if you prefer. I could leave those commented out with a note to re-enable them after Neogit is updated.

[nullchilly]

Yeah that sounds good

Remember we try not to be opinionated as much as possible

Personal reference is done via custom_highlight :)

I don't have a source to back up my claim but I think it is what the majority want

[mizlan]

Oh. I've got an idea. I'll use a more vibrant bg for "active" hunks right now. Will be easily visibly distinguishable while allowing both active and inactive to be readable.

[mizlan]

Quite fond of this setup: both are legible but one is grabs my attention more.

[nullchilly]

@mizlan Seems good!

We can merge this now if you want?

[mizlan]

Sure, go ahead! Can't find anything else for now.