Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(barbecue): add barbecue #377

Merged
merged 4 commits into from
Jan 13, 2023
Merged

feat(barbecue): add barbecue #377

merged 4 commits into from
Jan 13, 2023

Conversation

ofseed
Copy link
Contributor

@ofseed ofseed commented Dec 31, 2022

Coincidentally I found #376 after finishing it,
However, there are some differences between mine and his.
The main difference is that I use Conceal for the file path and it uses Normal,
which is a part that is unique to barbecue and not available in navic.
image

@nullchilly
Copy link
Contributor

Personally I think the folder path is a bit dim
@CnTeng thoughts?

@CnTeng
Copy link
Contributor

CnTeng commented Dec 31, 2022

I just copy the color from navic, maybe his choose is better.

@nullchilly
Copy link
Contributor

This version's dirname is too dim, we should cherry picking from @CnTeng 's PR

@ofseed
Copy link
Contributor Author

ofseed commented Dec 31, 2022

In fact, the dimed color is in recommended in barbecue's documentation. I think I can add an option to this pr for the user to decide this color later.

@ofseed
Copy link
Contributor Author

ofseed commented Dec 31, 2022

@nullchilly Done. Now you can customize the dirname color yourself.

@ofseed
Copy link
Contributor Author

ofseed commented Jan 5, 2023

And the new version of barbecue, which could generate colorscheme automatically, dims the dirname. So making it a default option is also a good choice.

@nullchilly nullchilly merged commit a15ac4b into catppuccin:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants