Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: style missing keywords #39

Merged
merged 1 commit into from Oct 9, 2021
Merged

feat: style missing keywords #39

merged 1 commit into from Oct 9, 2021

Conversation

luissolanodev
Copy link
Contributor

Because of semantic concerns, style from config should be applied to all
kinds of keywords separated by different highlight groups by Treesitter

@luissolanodev
Copy link
Contributor Author

luissolanodev commented Oct 5, 2021

Hey! @pocco81, this is what I was talking about in #36, to apply styling to all keywords. I left the colors the same, just added style, we can start with this and then figure out which colours look nicer, what do you think?

@pocco81
Copy link
Member

pocco81 commented Oct 6, 2021

Ooh ok ok now I understand. Are those all the keywords? Do have a list or something I could see? :)

Because of semantic concerns, style from config should be applied to all
kinds of keywords separated by different highlight groups by Treesitter
@luissolanodev
Copy link
Contributor Author

luissolanodev commented Oct 6, 2021

Hmmmmm obviously the list is different for each programming language, and I don't think there's a list of all the available highlights that correspond to keywords... but I looked at this list and all the keywords are highlighted accordingly, so it should be equivalent for other languages as well.

Edit: I added TSKeywordOperator for the new reserved keyword and TSBoolean for true and false reserved keywords.

@pocco81
Copy link
Member

pocco81 commented Oct 9, 2021

Great, I'll merge it :)

@pocco81 pocco81 merged commit 6de1122 into catppuccin:dev Oct 9, 2021
@luissolanodev luissolanodev deleted the keywords-style branch October 10, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants