Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transparent): winblend and popup #403

Merged
merged 3 commits into from Feb 12, 2023
Merged

fix(transparent): winblend and popup #403

merged 3 commits into from Feb 12, 2023

Conversation

nullchilly
Copy link
Member

@nullchilly nullchilly commented Feb 12, 2023

fix #401

With vim.o.winblend = 0 and vim.o.pumblend = 0 (default value in neovim):

image

With vim.o.winblend = 50 and vim.o.pumblend = 50:

image

Copy link
Collaborator

@EdenEast EdenEast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Could you also just validate that this works in vim as well. From reading the code it looks like it should but I have been surprised before.

@nullchilly
Copy link
Member Author

Pushed a fix for vim, seems to be working now

@nullchilly nullchilly merged commit a5f3ed5 into main Feb 12, 2023
@nullchilly nullchilly deleted the blend branch February 12, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert transparent background when winblend/pumblend option is set?
2 participants