Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for new lsp semantic token highlight groups #427

Merged
merged 2 commits into from Mar 9, 2023
Merged

feat: add support for new lsp semantic token highlight groups #427

merged 2 commits into from Mar 9, 2023

Conversation

mrtnvgr
Copy link
Collaborator

@mrtnvgr mrtnvgr commented Mar 9, 2023

Highlighting on nightly is broken right now, because of neovim/neovim#22022.

This PR is basically just recent commits from folke/tokyonight.nvim.

This needs to be tested, bc I'm not sure if I didn't break anything.

@nullchilly
Copy link
Member

I have no idea why @lsp.type.property is linked to Idenfifier, doesn't seem like a good idea from upstream.

@mrtnvgr
Copy link
Collaborator Author

mrtnvgr commented Mar 9, 2023

I have no idea why @lsp.type.property is linked to Idenfifier, doesn't seem like a good idea from upstream.

@lsp.type.property is linked to @property, isn't it?

@nullchilly nullchilly merged commit 0b29030 into catppuccin:main Mar 9, 2023
@mrtnvgr mrtnvgr deleted the lsp-semantic-token-groups branch March 9, 2023 11:25
@nullchilly
Copy link
Member

Merged as an emergency, thank you!

@akinsho akinsho mentioned this pull request Mar 9, 2023
Closed
@mrtnvgr mrtnvgr mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrtnvgr @nullchilly