Update desktop palettes #29
Conversation
|
Thanks a lot for updating the theme and fixing the mentioned issues!
This probably can easily be fixed by giving the chat area a different background (probably mantle) and highlighting pinned messages (either using crust or surface maybe?). I'm not entirely sure about the suggested solutions here tho. Open for other proposals as well. c: |
|
My bad. There are |
rossnomann
force-pushed
the
update-desktop
branch
from
aafa651
to
7e7e04f
Compare
|
Updated previews along with res.webp in 5fddeb6 . Also it looks like preview.png is not used anymore, so I removed it. |
rossnomann
force-pushed
the
update-desktop
branch
from
e79885a
to
e560a74
Compare
|
|
I would assume that most people set a separate background image anyway, so this is more of a placebo change for the most part. But for those few who are not using one this probably is a good change. c: |
|
I think wallpapers must be added by the one who owns the cpt* themes, because cpt*improved has wallpapers uploaded by me and I don't know what can happen with that wallpapers in future. |
|
I would recommend the following algorithm of adding a wallpaper to a theme: |
For me, this is the preferred way because telegram will generate a new link for the cloud wallpaper, which is not available in the gallery (chat settings). And probably you will not be able to remove it. You also can upload a wallpaper from Also I don't know what will happen with cloud wallpapers uploaded using the suggested way if my account will be blocked/deleted. That's why I think that the wallpaper must be uploaded by the theme owner. |
|
I don't think the wallpaper would become inaccessible as they are simply stored on Telegram's servers. It wouldn't make much sense to tie them to a specific user account. I don't even recall specifically adding them to the current themes either.. o: |
|
I hope you don't mind me pulling you in here @sgoudham. I'd like to hear your opinion on whether it's okay to eventually merge this and just have the TG Desktop theme be updated, or if there should be an effort to also edit the other themes (android, iOS, macOS) as well and release them alltogether. Personally I don't think it's an issue to update them step-by-step. but… idk. |
rossnomann
force-pushed
the
update-desktop
branch
from
a04c7bd
to
c454c7d
Compare
|
Added wallpapers and squashed commits. That's all from my side, I guess. |
|
Again; Thank you so much for your contributions! |
No worries about the ping. I suppose I don't have enough knowledge on how easy it is to edit the other themes alongside the desktop one but I'd imagine it's annoying since the contributor hasn't attempted it already. (or maybe they aren't interested) Ultimately, if it requires slight updates here and there then I don't mind this PR staying open for a bit longer but if there're a lot of changes to be made or if there's relatively little interest in it right now, we can totally merge this PR, raise issues to track the updates to the mobile versions and update them "step-by-step" as you mentioned. I'd definitely like to avoid this PR going stale for a long period of time 👍 |
|
While I'm here, a slight request from me, could we document the release process for the theme in another PR/commit? |
|
From what I've experienced with this in the past it's really annoying to convert the themes between the different versions of Telegram since the naming conventions between the different template files are vastly different. Telegram offers a tool that's supposed to convert themes, but this also doesn't seem to work properly.. The release process with Telegram themes is equally annyoing.. since right now they're tied to my personal Telegram account.. iirc there is a way to distribute themes as plain old files, but I haven't really looked into that too much but it might be a good alternative to the current link-based distribution. |
|
I've been test-driving this for a couple days and haven't found any bugs or quirks so far. I've upstreamed these changes; so the quote-unquote official links are up to date with this now. c: |
|
I've noticed that the scroll bar in the chat area is green instead of gray (overlay1/surface2). It happens when you are trying to save a theme via the theme editor in Telegram Desktop. I don't know how to fix that. But there is a workaround: just use themes.contest.com. To confirm that there is a bug: Click the "edit theme" button, choose the "tdesktop" tab, copy the palette, and make a diff with the original one from the repository. |
|
Oh, that's odd. On my end I don't even get a green scrollbar in the first place. I have initially distributed the themes through the themes website and have just updated the contents again. If this issue persists on your end; may I ask what platform and version you're on; maybe the issue is burried in there somewhere?
|
|
https://t.me/addtheme/ctp_mocha
|
|
Thank you both for your work on this theme! I love the work being done, just one suggestion I have is using subtext colors rather than all text for when you're on the main menu page with all the messages. Changing it over to subtext would make more sense. What I mean is making the message preview not the same color as the channel name. Telegram Desktop 4.16.8 (arch repo)
|
This PR makes desktop palettes more readable and adds some missing variables, such as
groupCall*Also
--accentflag is added to allow to change accent color. Green is the default accent.Examples:
https://t.me/addtheme/ctpmochaimproved
https://t.me/addtheme/ctpmacchiatoimproved
https://t.me/addtheme/ctpfrappeimproved
https://t.me/addtheme/ctplatteimproved
Closes #24; Closes #25;
I'm not sure what's going on in #27 but now you can change accent color.