Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catwalk: Side-by-Side Grid Layout request. #20

Closed
isabelincorp opened this issue Oct 19, 2022 · 4 comments · Fixed by #60 or #61
Closed

Catwalk: Side-by-Side Grid Layout request. #20

isabelincorp opened this issue Oct 19, 2022 · 4 comments · Fixed by #60 or #61
Assignees
@nekowinston
Labels
enhancement New feature or request

Comments

@isabelincorp
Copy link
Member

isabelincorp commented Oct 19, 2022 •
edited

So that instead of (2x2)

A  B
A  B

C  D
C  D

It would be (4x1)

A B C D
A B C D

This would work really well with mobile screenshots, as currently catwalk isn't ideal for mobile screenshots.
@isabelincorp isabelincorp added the enhancement New feature or request label Oct 19, 2022
@isabelincorp
Copy link
Member Author

Perhaps maybe implementing a dimension variable into --layout grid could solve this so for example for normal grid (ideal for desktop screenshots) it would be --layout grid 2,2 then for the mobile grid it would be --layout grid 4,1, another possible layout could be --layout grid 1,4 that gives you which could be used for ports like st

AA
BB
CC
DD

(variables are horizontal,vertical)

@JoshPaulie
Copy link
Member

I'd be happy to implement this, but the specifics are tripping me up.

Wouldn't a 2x2 look like

A B
C D

While 4x1 would look like

A B C D

@isabelincorp
Copy link
Member Author

Yep pretty much.

@nekowinston nekowinston self-assigned this Jul 31, 2023
nekowinston added a commit that referenced this issue Nov 3, 2023
@nekowinston
feat: add 4x1 layout
9d95725 
Closes #20
@nekowinston nekowinston mentioned this issue Nov 3, 2023
Merged
nekowinston added a commit that referenced this issue Nov 4, 2023
@nekowinston
feat: add --layout row (#60)
00f26b5 
Closes #20
@github-actions github-actions bot mentioned this issue Nov 4, 2023
Merged
@nekowinston
Copy link
Member

nekowinston commented Nov 4, 2023 •
edited

Implemented in catwalk v1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekowinston nekowinston

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --layout row catppuccin/toolbox
chore: release main catppuccin/toolbox
3 participants
@JoshPaulie @nekowinston @isabelincorp