Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(whiskers): create needed parent directories by default #182

Merged
merged 2 commits into from Apr 27, 2024

Conversation

backwardspy
Copy link
Member

@backwardspy backwardspy commented Apr 27, 2024

BEGIN_COMMIT_OVERRIDE
feat(whiskers): create needed parent directories by default
END_COMMIT_OVERRIDE

@backwardspy backwardspy self-assigned this Apr 27, 2024
@backwardspy backwardspy added enhancement New feature or request whiskers Issues relating to whiskers labels Apr 27, 2024
whiskers/README.md Outdated Show resolved Hide resolved
@nekowinston
Copy link
Member

FWIW, I would expect this to be the default. I don't have to tell most build systems to generate the dist directory if I haven't done so manually.

As an aside, you probably want to keep using Conventional Commit PR titles, if you want PRs like this and #179 to show up in #174 automatically.

@backwardspy
Copy link
Member Author

backwardspy commented Apr 27, 2024

FWIW, I would expect this to be the default. I don't have to tell most build systems to generate the dist directory if I haven't done so manually.

i've been back and forth on this a bit, i agree for build tools it makes sense for this to just happen. i'll think about it some more.

As an aside, you probably want to keep using Conventional Commit PR titles, if you want PRs like this and #179 to show up in #174 automatically.

is that done based on PR titles? i assumed it would look at commits instead. will change them now!

edit: ah, but i screwed up the commit message when i squashed 😅 there's as good a reason as any to just title the PR with it too. point taken!

@backwardspy backwardspy changed the title add --create-parent-dirs option feat(whiskers): add --create-parent-dirs option Apr 27, 2024
@nekowinston
Copy link
Member

is that done based on PR titles? i assumed it would look at commits instead. will change them now!

https://github.com/catppuccin/toolbox/actions/runs/8858928452/job/24328133362#step:2:127

It's looking at the PRs, both at the title and text content, since you can override them retroactively with

BEGIN_COMMIT_OVERRIDE
type(scope): message
END_COMMIT_OVERRIDE

You should be able to just add that into #179 and it will show up in the changelog the next time release-please runs on main.

@backwardspy
Copy link
Member Author

we discussed this a little further and concluded that it does make sense to just do this by default, especially as this change to create directories is pretty non-destructive. overwriting existing files would possibly be a different discussion, but we're already doing that without an associated flag.

i've removed the cli flag entirely as i can't think of a reason to disable this behaviour. if one comes up, i think it should be rolled into the same change as the aforementioned overwriting of files.

@backwardspy backwardspy merged commit 0cd4327 into main Apr 27, 2024
3 checks passed
@backwardspy backwardspy deleted the feat/create-parents branch April 27, 2024 11:01
@backwardspy
Copy link
Member Author

thanks for the review & discussion!

@github-actions github-actions bot mentioned this pull request Apr 27, 2024
@backwardspy backwardspy changed the title feat(whiskers): add --create-parent-dirs option feat(whiskers): create needed parent directories by default Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request whiskers Issues relating to whiskers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants