Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add liquid icon #53

Merged
merged 2 commits into from
Oct 29, 2023
Merged

feat: add liquid icon #53

merged 2 commits into from
Oct 29, 2023

Conversation

nekowinston
Copy link
Contributor

Closes #52

@brady-sewall if there are any extra files/extensions this icon should cover, please let me know.

@brady-sewall
Copy link

Closes #52

@brady-sewall if there are any extra files/extensions this icon should cover, please let me know.

The only other file type that is missing is dot files (showing a generic file type). Not a big deal, unless you feel like customizing.
image

@nekowinston
Copy link
Contributor Author

I added the icon association for .liquidrc and .liquidrc.json, I think .shopifyignore/other Shopify files would warrant their own icons.

.tool-versions is asdf, right?

@brady-sewall
Copy link

brady-sewall commented Oct 25, 2023

I added the icon association for .liquidrc and .liquidrc.json, I think .shopifyignore/other Shopify files would warrant their own icons.

.tool-versions is asdf, right?

I'm not sure if it's asdf. Inside just lists the nodejs version.

EDIT: Yes, it appears to be asdf 👍

@prazdevs prazdevs merged commit cdc17c0 into main Oct 29, 2023
2 checks passed
@prazdevs prazdevs deleted the feat/add-liquid-icon branch October 29, 2023 01:10
@brady-sewall
Copy link

@prazdevs I updated to the latest build as of today, restarted VS Code and it looks like the liquid and dot files are still unthemed. Am I mistaken that this commit was included in the build today?

image

@prazdevs
Copy link
Member

@j-moltz
Copy link

j-moltz commented Feb 1, 2024

Thank you for creating this icon! Something seems to have happened between the end of October commits when this icon was created and added and the December commits, as the liquid icon is no longer part of the set. Could it be re-added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon request] Liquid file icons
4 participants