feat: match JetBrains Syntax more closely #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit improves Python Highlights, copied from our JetBrains theme: VSCode: JetBrains: |
nekowinston
changed the title
nekowinston
force-pushed
the
refactor/split-tokens
branch
from
8dc798a
to
a0b5a11
Compare
This was referenced Oct 29, 2022
Closed
nekowinston
added
enhancement
|
+1 need this. |
This was referenced May 19, 2023
nekowinston
force-pushed
the
refactor/split-tokens
branch
from
a0b5a11
to
d081169
Compare
|
Can you do this for JavaScript/TypeScript as well?🙏 |
|
Scrapping this PR in favor of a later one |
This was referenced Sep 1, 2023
nekowinston
added a commit
that referenced
this pull request
Sep 2, 2023
Re-implements most changes that #53 did for python.
nekowinston
added a commit
that referenced
this pull request
Sep 2, 2023
Re-implements most changes that #53 did for python.
nekowinston
added a commit
that referenced
this pull request
Sep 2, 2023
* feat!(syntax): rework syntax highlighting * feat(syntax): yaml adjustments * feat(syntax): remove italic keywords in compiler * feat(syntax): add more semantic tokens * feat(syntax): remove illegal/deprecated highlight * feat(syntax): property name from json -> inherited (toml, etc.) * feat(syntax): add markdown * feat(syntax): revert semantic peach HLs for constants * feat(syntax): add ini * feat(syntax): module.exports in cjs * feat(syntax): semantic parameters red -> maroon * feat(syntax): reset most semantic tokens * feat(syntax): port python changes from #53 Re-implements most changes that #53 did for python. * feat(syntax): add fontStyle to all tokens * feat(syntax): disable semantic hl, adjust for TS code * feat(syntax): add JSX/TSX/Astro * feat(syntax): markdown language identifier * feat(syntax): css/less/scss & php * feat(syntax): markdown backticks & leading # for headers * feat(syntax): css/html improvements, svelte support, php dollar sign * feat(syntax): treat const in JS/TS as variable * ci(lint): only run on main branch for push events * feat(syntax): set generic `punctuation.definition.variable` to text * feat(syntax): add dotenv support * feat(syntax): reenable semantic tokens, scoped to python, update python * feat(syntax): use `red` for self/this * feat(syntax): ignore peach on const semantic for JS/TS * feat(syntax): add more exceptions for keywords * feat(syntax): shell variables in strings, shebang * feat(syntax): ruby internal functions * feat(syntax): js/ts properties * feat(syntax): css vendored properties * feat(syntax): TOML array keys & ini sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR split our Token definitions into separate files per language.
I also noticed that we re-define Strings to be green about 80 times, as well as other tokens.
Everything should be looked over, we should inherit more from global definitions.