Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #721

Open
kayman-mk opened this issue Feb 27, 2023 · 0 comments
Open

Add unit tests #721

kayman-mk opened this issue Feb 27, 2023 · 0 comments
Labels
enhancement 🆕 New feature or request help wanted Extra attention is needed work-in-progress Issue/PR is worked, should not become stale

Comments

@kayman-mk
Copy link
Collaborator

kayman-mk commented Feb 27, 2023

Currently we provindig a few lamba's as part of the module. However the code is simple, it is good practice to have unit tests. Unit helps to check the code in isolation, without the need to deploy the lambda. Unit test will help to check dependency changes and PR in an automate way.

I think we should setup tests with pytest to test the Lambda's in isolation, including expection behavior. Calls to external API's such as AWS SDK (via boto3). can be mocked. Test should focus on checking the internal behaviror.

Unit tests for the module are still missing and would improve the quality of the project. #632 already started to implement tests.

Things to test:

@kayman-mk kayman-mk added enhancement 🆕 New feature or request new ⭐ Brand new and maintainers haven't seen it yet help wanted Extra attention is needed and removed new ⭐ Brand new and maintainers haven't seen it yet labels Feb 27, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label May 16, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label May 18, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Jul 18, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Jul 27, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Sep 26, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Sep 28, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 16, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 16, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 16, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Jan 16, 2024
@kayman-mk kayman-mk added work-in-progress Issue/PR is worked, should not become stale and removed stale Issue/PR is stale and closed automatically labels Jan 19, 2024
@cattle-ops cattle-ops deleted a comment from github-actions bot Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆕 New feature or request help wanted Extra attention is needed work-in-progress Issue/PR is worked, should not become stale
Projects
None yet
Development

No branches or pull requests

1 participant