-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cancel spot requests #653
Merged
kayman-mk
merged 8 commits into
cattle-ops:main
from
Hapag-Lloyd:kayma/remove-spot-requests
Mar 2, 2023
Merged
feat: cancel spot requests #653
kayman-mk
merged 8 commits into
cattle-ops:main
from
Hapag-Lloyd:kayma/remove-spot-requests
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JulianCBC
reviewed
Feb 17, 2023
npalm
previously approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good not the time right now to test. Would suggest the following
- Add a module readme to describe shortly what the lambda does
- Add a backlog itme to add unti test.
Oh yes, missed to update the Issue for unit tests created (#721) |
npalm
previously approved these changes
Feb 27, 2023
merge conflicts fixed |
npalm
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever a spot executor is created a spot request is created. Occasionally there might be open spot requests which have not been fulfilled. These spot requests have to be deleted as soon as the agent terminates as no executors are needed.
Challenge: Make sure that spot requests are deleted only which belong to our module. Unfortunately the GitLab Runner does not tag them. We use the following logic for determinination:
runner
var.environment
/var.overrides['name_docker_machine']
somewhere in the nameSolves part of #623
Closes #493
Migrations required
No.
Verification
Removing open spot requests for environment
and print eitherSpot requests deleted
orNo open spot requests found
. There are no errors in the log.