Some FsMessageTemplate tests failing

[haf]

I rewrapped the tests properly in as Expecto tests:

And these are failing:

(examples)

[16:03:51 ERR] logary/message templates/alignment/10: cus #{CustomerId,10:000000}, pleasure to see you failed in 00:00:00.
format should work.
          Expected string to equal:
          "cus #    001234, pleasure to see you"
                ↑
          The string differs at index 5.
          "cus #001234    , pleasure to see you"
                ↑
          String does not match at position 5. Expected char: ' ', but got '0'.
  /Users/h/dev/logibit/logary/src/Logary.Tests/FsMessageTemplates.fs(67,1): Logary.Tests.FsMessageTemplates.RenderedAs@67-8.Invoke(AssertException exn)
 <Expecto>
[16:03:51 ERR] logary/message templates/alignment/9: cus #{CustomerId,10}, pleasure to see you failed in 00:00:00.
format should work.
          Expected string to equal:
          "cus #      1234, pleasure to see you"
                ↑
          The string differs at index 5.
          "cus #1234      , pleasure to see you"
                ↑
          String does not match at position 5. Expected char: ' ', but got '1'.
  /Users/h/dev/logary/src/Logary.Tests/FsMessageTemplates.fs(67,1): Logary.Tests.FsMessageTemplates.RenderedAs@67-8.Invoke(AssertException exn)
 <Expecto>
[16:03:51 ERR] logary/message templates/alignment/8: cus #{CustomerId,-10:000000}, pleasure to see you failed in 00:00:00.
format should work.
          Expected string to equal:
          "cus #001234    , pleasure to see you"
                ↑
          The string differs at index 5.
          "cus #    001234, pleasure to see you"
                ↑
          String does not match at position 5. Expected char: '0', but got ' '.
  /Users/h/dev/logary/src/Logary.Tests/FsMessageTemplates.fs(67,1): Logary.Tests.FsMessageTemplates.RenderedAs@67-8.Invoke(AssertException exn)
 <Expecto>

Repro: cd src/Logary.Tests && dotnet run --framework netcoreapp2.0 => [16:03:52 INF] EXPECTO! 455 tests run in 00:00:02.6205660 for logary – 430 passed, 11 ignored, 14 failed, 0 errored. ( ರ Ĺ̯ ರೃ ) <Expecto>

Do you think you could have a look @adamchester ?

[adamchester]

Hey @haf, I couldn't repro this.

~logary\src\Logary.Tests>dotnet run --framework netcoreapp2.0 --sequenced
[15:02:38 INF] EXPECTO? Running tests... <Expecto>
...
[15:02:46 INF] EXPECTO! 460 tests run in 00:00:07.6868294 for logary - 433 passed, 27 ignored, 0 failed, 0 errored. Success! <Expecto>

[adamchester]

I just noticed they're ignored... investigating further...

[adamchester]

OK, I found some gaps in the tests for alignment over in F# MtParserFull which I'll have to address over there first. It will probably result in a new file we can paket-reference here.

However, the first issue here seems to be in Logary.MessageTemplates.Formatting.Literate.tokeniseProperty:

match pt.align.direction with
|  AlignDirection.Right -> formated.PadRight(pt.align.width, ' ')
|  AlignDirection.Left -> formated.PadLeft(pt.align.width, ' ')

When it's AlignDirection.Left then the extra spaces (padding) should be on the right, and vice-versa. So, it should be: Right -> PadLeft and Left -> PadRight

I've confirmed this interpretation with the following tests against Serilog and String.Format:

void Main()
{
    using (var logger = new LoggerConfiguration()
        .WriteTo.Console(outputTemplate: "{Source}: {Message}{NewLine}")
        .CreateLogger())
    {
        var log = logger.ForContext("Source", "Serilog");
        log.Information("{p1,-10} | {p2,10}", "a", "a");
        log.Information("{p1,-10} | {p2,10}", "aa", "aa");
        log.Information("{p1,-10} | {p2,10}", "aaaa", "aaaa");

        log = logger.ForContext("Source", "string.Format (C#)");
        log.Information($"\"{"a",-10}\" | \"{"a",10}\"");
        log.Information($"\"{"aa",-10}\" | \"{"aa",10}\"");
        log.Information($"\"{"aaaa",-10}\" | \"{"aaaa",10}\"");

        log = logger.ForContext("Source", "string.Format (BCL)");
        log.Information(string.Format("{0,-10} | {1,10}", "a", "a"));
        log.Information(string.Format("{0,-10} | {1,10}", "aa", "aa"));
        log.Information(string.Format("{0,-10} | {1,10}", "aaaa", "aaaa"));
    }
}

[haf]

I've fixed all but two of these tests.