Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitForBuffers handling in processing? #348

Closed
haf opened this issue Jun 12, 2018 · 3 comments
Closed

waitForBuffers handling in processing? #348

haf opened this issue Jun 12, 2018 · 3 comments
Milestone

Comments

@haf
Copy link
Member

haf commented Jun 12, 2018

Unhandled exception: System.Exception: logWithAck (true, _) should have waited for the RingBuffer(s) to accept the Message. Target(console)
@haf haf changed the title Should be passed along in Facade v4 waitForBuffers: Should be passed along in Facade v4 Jun 12, 2018
@haf haf changed the title waitForBuffers: Should be passed along in Facade v4 waitForBuffers handling in processing? Jun 13, 2018
@haf haf closed this as completed in 9185577 Jun 13, 2018
@haf haf reopened this Jun 13, 2018
@haf haf added this to the v5.0 milestone Jun 19, 2018
@lust4life
Copy link
Contributor

#378 , log error can be handled by config a result handler on registry , and the default one

@haf
Copy link
Member Author

haf commented Dec 14, 2018

@lust4life Thanks, so with your PR, this should be fixed, I suppose? Since you switched from 'rejected' as the default to 'accepted' as the default?

@lust4life
Copy link
Contributor

these are two different things, if target not accept a message,this will result a log error message to registry's logErrorHandler.

changing pipeline processing result (NoResult) to acceptable is for fire-forget. e.g. user log a message, goto a pipe which have a buffer sink, it will only push to target by batches. So at this logging time, this message are in pipe's buffer, not in target, but we assume that this logging result is success.

@haf haf closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants