Check for missing filename directive in Content-disposition #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check in
guessFilename(resp *http.Response)
function to make sure that the we only read thefilename
from theContent-disposition
header when thefilename
directive is supplied as it's completely legal and valid [source] for the server to just returninline
orattachment
directives without supplying thefilename
If we can't read the name from the header we simply fallback to
URL.Path
forfilename
value.This PR fixes #64