Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement version generation using git-describe #2

Closed
ghost opened this issue Aug 13, 2019 · 6 comments
Closed

Implement version generation using git-describe #2

ghost opened this issue Aug 13, 2019 · 6 comments
Labels
bug Something isn't working
Projects
Initial Setup
Milestone
SVN switchover

Comments

@ghost
Copy link

ghost commented Aug 13, 2019

No description provided.

@ghost ghost added this to To do in Initial Setup via automation Aug 13, 2019
@ghost ghost assigned ghost and unassigned ghost Aug 13, 2019
@ghost
Copy link
Author

ghost commented Aug 13, 2019

@billw2012
Something like https://stackoverflow.com/a/8358264 could work for us.

@billw2012
Copy link
Member

Yeah I did exactly this in my previous project

@billw2012 billw2012 added the bug Something isn't working label Aug 15, 2019
@billw2012 billw2012 added this to the SVN switchover milestone Aug 15, 2019
@ghost ghost self-assigned this Aug 15, 2019
@billw2012
Copy link
Member

This works now right?

@ghost
Copy link
Author

ghost commented Aug 19, 2019 •
edited by ghost

One thing that's left to do is not overwriting the version.cpp if it already has the same content as the new file would have.

@ghost
Copy link
Author

ghost commented Aug 20, 2019

The commit caveman2cosmos/C2C-GitVersion@680833e contains the change to not overwrite the version.cpp if it already exists and contains the same code as the new file would.

@ghost
Copy link
Author

ghost commented Aug 20, 2019

One thing that's left to do is not overwriting the version.cpp if it already has the same content as the new file would have.
Done in 7eb4fc1

@ghost ghost closed this as completed Aug 20, 2019
Initial Setup automation moved this from To do to Done Aug 20, 2019
billw2012 pushed a commit that referenced this issue Jan 12, 2020
@MattOttawa
Merge pull request #2 from caveman2cosmos/master
ededc65 
merge master branch
raxo2222 pushed a commit that referenced this issue Feb 29, 2020
@SannitaSSJ
Merge pull request #2 from caveman2cosmos/master
be3615f 
Update #2
raxo2222 pushed a commit that referenced this issue Mar 8, 2020
@dsmabell
Merge pull request #2 from caveman2cosmos/master
4a61b9c 
Update
SannitaSSJ added a commit that referenced this issue Dec 11, 2020
@SannitaSSJ
Bonus cleanup #2
ed6b42d 
adding pedia entry for Atompunk (en, it) + labels for Hit Animated Movies (en, it); several minor fixes
typo
SannitaSSJ added a commit that referenced this issue Dec 13, 2020
@SannitaSSJ
fixing the problem, attempt #2
8217e14
dzfischer added a commit that referenced this issue Feb 6, 2023
@dzfischer
Improvements limited to influenced tiles attempt #2
7af3f1b
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Initial Setup
  
Done
Milestone
SVN switchover
Development

No branches or pull requests
1 participant
@billw2012