Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary log file creation function calls #28

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

sneak-it
Copy link
Contributor

This is a slight rollback of commit c444081

The CreateLogFile function simply builds the path out to the CV logfile. It is unnecessary to call it more than once outside of the start of the plugin - this removes the redundancies.

@caxanga334
Copy link
Owner

The CreateLogFile adds a timestamp to the log file. This is why it's called multiple times.

@caxanga334 caxanga334 self-assigned this Feb 15, 2022
@caxanga334 caxanga334 added this to To do in Development via automation Feb 15, 2022
@sneak-it
Copy link
Contributor Author

The CreateLogFile adds a timestamp to the log file. This is why it's called multiple times.

Good point, I believe it would be appropriate in this case to build the path in OnMapStart - unless you expect some folks have servers that run one map more than 24 hours without changing.

Calling this func every time there is a vote is definitely unnecessary.

@caxanga334
Copy link
Owner

Good point, I believe it would be appropriate in this case to build the path in OnMapStart - unless you expect some folks have servers that run one map more than 24 hours without changing.

Servers that never changes map is the reason I call it every time there is a vote.

@caxanga334 caxanga334 merged commit e6ba26e into caxanga334:master Feb 15, 2022
Development automation moved this from To do to Done Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants