Revert formula characters other than = #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2023
Closed
kiskoza
approved these changes
Apr 22, 2023
|
Thanks for the quick response! I think it does the right thing. I’ll look at it in detail later today. |
|
(I especially want to think about the tests – do all current tests regarding this behaviour still make sense, do we need additional / different tests, …) |
|
@noniq re: tests, this reverts us back the to the 3.3.0 behavior, so I'd say let's go ahead and merge and release this as 3.4.1 to "stop the bleeding" for existing users, while we conduct further investigation here. Any change to the behavior (if needed) should be released as part of 4.0.0. |
|
Merged. I also added some tests that would fail with the (now reverted) behaviour from 3.4.0, just to make sure we won’t run into this problem in the future again. Thank you! Let’s release 3.4.1 asap. |
noniq
referenced
this pull request
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #190 based on @noniq's comment. Fixes #207, #208.
Suggest to release as 3.4.1.