Add optional interpolation points to icon sets #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
reviewed
May 31, 2023
| def initialize_value_objects | ||
| @value_objects = SimpleTypedList.new Cfvo | ||
| @value_objects.concat [Cfvo.new(:type => :percent, :val => 0), Cfvo.new(:type => :percent, :val => 33), Cfvo.new(:type => :percent, :val => 67)] | ||
| @interpolationPoints.each { |point| @value_objects << Cfvo.new(type: :percent, val: point) } |
There was a problem hiding this comment.
Hi, this should also fix a false positive in rubocop, can you please try to regenerate the config and check if the todo changes?
rubocop --auto-gen-config --no-auto-gen-timestamp --no-offense-counts
I expect that Style/ConcatArrayLiterals offence will be removed
There was a problem hiding this comment.
thanks, I ran the rubocop and removed the todo from the list
kiskoza
force-pushed
the
221-icon-set-improvements
branch
from
8205dd2
to
86e2062
Compare
kiskoza
force-pushed
the
221-icon-set-improvements
branch
from
86e2062
to
9e614b8
Compare
kiskoza
force-pushed
the
221-icon-set-improvements
branch
from
9e614b8
to
8639312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #221
I turned the code snippet from #221 into a PR.
I renamed the new attribute to
interpolationPointsas theCfvoclass refers to them as interpolation points in the comments (then asvalin the code).I also had to move the call for
initialize_value_objectsinto theto_xml_stringmethod as we can override the interpolation points any time before the actual serialization. I'm not sure if we really need to store it in memory, it could be handy only if we callto_xml_stringmultiple times on the same iconSet.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.