Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tmp/use validated attr accessors #323

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Nov 24, 2023

Based on #321

This change will reduce and DRY code by using
existing validated accessors

@tagliala tagliala force-pushed the tmp/use-validated-attr-accessors branch from df3f19b to 416ac0f Compare November 24, 2023 23:31
@tagliala tagliala changed the title Tmp/use validated attr accessors [WIP] Tmp/use validated attr accessors Nov 24, 2023
@tagliala tagliala force-pushed the tmp/use-validated-attr-accessors branch from 416ac0f to 56b727a Compare November 28, 2023 15:15
@tagliala
Copy link
Contributor Author

tagliala commented Nov 28, 2023

Still WIP

Master at cf06452 (condensed lines)

5612 / 5640 LOC (99.5%) covered.

Before

6049 / 6106 LOC (99.07%) covered.

After

5521 / 5562 LOC (99.26%)

@tagliala tagliala force-pushed the tmp/use-validated-attr-accessors branch from 56b727a to 7fff1ba Compare November 28, 2023 15:53
@tagliala tagliala force-pushed the tmp/use-validated-attr-accessors branch 3 times, most recently from ab4bc11 to 58a2260 Compare December 13, 2023 12:23
This change will reduce and DRY code by using
existing validated accessors
@tagliala tagliala force-pushed the tmp/use-validated-attr-accessors branch from 58a2260 to 914195c Compare December 13, 2023 15:37
@kiskoza kiskoza mentioned this pull request Feb 26, 2024
7 tasks
Copy link

This pull request has been automatically marked as stale because has been no activity for at least three months.
If you have any new information or updates please reply in order to keep the pull request open.

@github-actions github-actions bot added the stale Will be closed soon if there are no updates. label Mar 13, 2024
@tagliala
Copy link
Contributor Author

keep open

@github-actions github-actions bot removed the stale Will be closed soon if there are no updates. label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant