Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: manageable markers for scatter series #85

Merged

Conversation

olegykz
Copy link
Contributor

@olegykz olegykz commented Mar 1, 2021

Currently, scatter series would have the markers despite the style of scatter chart. This PR introduces the possibility to hide the markers if scatter style implies markers' absence.
Additionally, it would allow customizing marker symbol in the same way as LineSeries allows

@noniq
Copy link
Member

noniq commented Mar 20, 2021

Thanks! I have almost no experience with scatter charts, so I’m not sure I really understand what’s going on here.

Could you provide some examples of how this PR changes the behaviour when generating scatter charts?

@olegykz
Copy link
Contributor Author

olegykz commented Mar 24, 2021

@noniq this PR has no anything specific to scatter charts and rather synchronizing ability to config marker symbols with line charts (and line series) -

@marker_symbol = options[:marker_symbol] ? options[:marker_symbol] : :default

the only difference is that the scatter series has a set of possible styles (line, lineMarker, marker, smooth, smoothMarker) and some of them (smooth, line) - indicate that we should not have the marker at all

@github-actions
Copy link

This pull request has been automatically marked as stale because has been no activity for at least three months. It will be automatically closed in 7 days.
If you have any new information or updates please reply in order to keep the pull request open.

@github-actions github-actions bot added the stale Will be closed soon if there are no updates. label Jun 23, 2021
@github-actions github-actions bot closed this Jun 30, 2021
@straydogstudio
Copy link
Contributor

Hasn't been much activity here, but I don't think it should be closed.

@github-actions github-actions bot closed this Sep 18, 2021
@olegykz
Copy link
Contributor Author

olegykz commented Jan 10, 2022

@straydogstudio I guess this one also still could be useful

@straydogstudio straydogstudio removed the stale Will be closed soon if there are no updates. label Jan 12, 2022
@straydogstudio
Copy link
Contributor

@olegykz Would you add an entry to the changelog?

@olegykz
Copy link
Contributor Author

olegykz commented Feb 7, 2022

@straydogstudio done

@straydogstudio straydogstudio merged commit be9b3e6 into caxlsx:master Feb 7, 2022
@olegykz olegykz deleted the feature/manageable-scatter-markers branch February 7, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants