New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: manageable markers for scatter series #85
feature: manageable markers for scatter series #85
Conversation
Thanks! I have almost no experience with scatter charts, so I’m not sure I really understand what’s going on here. Could you provide some examples of how this PR changes the behaviour when generating scatter charts? |
@noniq this PR has no anything specific to scatter charts and rather synchronizing ability to config marker symbols with line charts (and line series) - caxlsx/lib/axlsx/drawing/line_series.rb Line 40 in 282eec4
the only difference is that the scatter series has a set of possible styles (line, lineMarker, marker, smooth, smoothMarker) and some of them (smooth, line) - indicate that we should not have the marker at all |
This pull request has been automatically marked as stale because has been no activity for at least three months. It will be automatically closed in 7 days. |
Hasn't been much activity here, but I don't think it should be closed. |
@straydogstudio I guess this one also still could be useful |
@olegykz Would you add an entry to the changelog? |
@straydogstudio done |
Currently, scatter series would have the markers despite the style of scatter chart. This PR introduces the possibility to hide the markers if scatter style implies markers' absence.
Additionally, it would allow customizing marker symbol in the same way as LineSeries allows