Implement Resolver iterator #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyrwork
force-pushed
the
resolver-iterator
branch
4 times, most recently
from
07bd42f
to
6072cdd
Compare
dennwc
requested changes
Oct 18, 2018
graph/iterator/resolver.go
Outdated
| nodes: make([]quad.Value, 0, 20), | ||
| } | ||
| // Enforce uniqueness | ||
| unique := make(map[quad.Value]bool, 20) |
There was a problem hiding this comment.
I would actually expect it to iterate over duplicates. It might resolve duplicates once, but in general, it should preserve an order and the number of values.
graph/iterator/resolver_test.go
Outdated
|
|
||
| func TestResolverIteratorIterate(t *testing.T) { | ||
| var ctx context.Context | ||
| qs, err := cayley.NewMemoryGraph() |
There was a problem hiding this comment.
Requiring the top-level cayley package from low-level iterators package is a bit an overkill. Please check other iterator tests, there should be a mock store for such tests.
| package iterator_test | ||
|
|
||
| import ( | ||
| "testing" |
There was a problem hiding this comment.
running goimports over it will be nice (analog of gofmt)
phyrwork
force-pushed
the
resolver-iterator
branch
from
6072cdd
to
4d5578d
Compare
dennwc
reviewed
Oct 18, 2018
phyrwork
force-pushed
the
resolver-iterator
branch
from
4d5578d
to
07ef7be
Compare
dennwc
reviewed
Oct 20, 2018
graph/iterator/resolver.go
Outdated
| func (it *Resolver) Contains(ctx context.Context, value graph.Value) bool { | ||
| graph.ContainsLogIn(it, value) | ||
| if !it.cached { | ||
| it.resolve(ctx) |
There was a problem hiding this comment.
It should set it.err, same for Next
graph/iterator/resolver.go
Outdated
| // Next advances the iterator. | ||
| func (it *Resolver) Next(ctx context.Context) bool { | ||
| graph.NextLogIn(it) | ||
| if it.index == len(it.order) { |
Implement an iterator that takes a slice of nodes and an associated QuadStore and resolves to their respective values during iteration. Resolves cayleygraph#663
phyrwork
force-pushed
the
resolver-iterator
branch
from
07ef7be
to
9ff9edc
Compare
|
@phyrwork There are only a few small changes left. Do you have time to finish it? Will be happy to merge it. |
dennwc
approved these changes
Nov 26, 2018
|
Nevermind, I fixed and merged it. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement an iterator that takes a slice of nodes and an
associated QuadStore and resolves to their respective
values during iteration.
Resolves #663