scummvm: Fix build with upcoming fluidsynth 2.2.0 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluidsynth 2.2.0 introduced API changes causing:
| audio/softsynth/fluidsynth.cpp:256:11: error: invalid conversion from 'long int (*)(void*)' to 'fluid_sfloader_callback_tell_t' {aka 'long long int (*)(void
The change should be compatible for version < 2.2.0 either
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 7, 2021
The only fallout by API/ABI changes in my world build was meta-games/scummvm.
Fix was sent [1]
fluidsynth 2.2.0
This release breaks ABI compatibility! Refer to the API docs for details.
A C++98 compliant compiler is now required to build fluidsynth (mailing list thread)
New features
Support loading SoundFonts >2GiB on Windows (openembedded#629)
Major overhaul of the sequencer and its event queue (openembedded#604)
Overlapping notes can be handled (openembedded#637)
Performance improvement, since the event queue no longer blocks the rendering thread
Time scale is not limited to 1000 anymore and can therefore be used for tempo changes
The following audio drivers have gained multi-channel support
DSound (openembedded#667, thanks to @jjceresa)
WaveOut (openembedded#667, thanks to @jjceresa)
The WinMIDI driver supports multiple devices (openembedded#677, thanks to @jjceresa)
Handle GS DT1 SysEx messages for setting whether a channel is used for rhythm part (openembedded#708, thanks to @chirs241097)
Support use of UTF-8 filenames under Windows (openembedded#718, thanks to @getraid-gg)
Improved support for overriding tempo of the MIDI player (openembedded#711, openembedded#713, thanks to @jjceresa)
Handle settings-related commands in user command file before initializing other objects (openembedded#739)
SoundFont loading has been parallelized (openembedded#746, openembedded#812, requires openMP)
The Oboe driver has gained a lower latency and other updates (openembedded#740, openembedded#741, openembedded#747)
WASAPI driver has been added (openembedded#754, thanks to @chirs241097)
General
Fix race condition in fluid_player_callback (openembedded#783, thanks to @arcln)
Improvements to LADSPA subsystem (openembedded#795, thanks to @mawe42)
[1] cazfi/meta-games#58
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 8, 2021
The only fallout by API/ABI changes in my world build was meta-games/scummvm.
Fix was sent [1]
fluidsynth 2.2.0
This release breaks ABI compatibility! Refer to the API docs for details.
A C++98 compliant compiler is now required to build fluidsynth (mailing list thread)
New features
Support loading SoundFonts >2GiB on Windows (openembedded#629)
Major overhaul of the sequencer and its event queue (openembedded#604)
Overlapping notes can be handled (openembedded#637)
Performance improvement, since the event queue no longer blocks the rendering thread
Time scale is not limited to 1000 anymore and can therefore be used for tempo changes
The following audio drivers have gained multi-channel support
DSound (openembedded#667, thanks to @jjceresa)
WaveOut (openembedded#667, thanks to @jjceresa)
The WinMIDI driver supports multiple devices (openembedded#677, thanks to @jjceresa)
Handle GS DT1 SysEx messages for setting whether a channel is used for rhythm part (openembedded#708, thanks to @chirs241097)
Support use of UTF-8 filenames under Windows (openembedded#718, thanks to @getraid-gg)
Improved support for overriding tempo of the MIDI player (openembedded#711, openembedded#713, thanks to @jjceresa)
Handle settings-related commands in user command file before initializing other objects (openembedded#739)
SoundFont loading has been parallelized (openembedded#746, openembedded#812, requires openMP)
The Oboe driver has gained a lower latency and other updates (openembedded#740, openembedded#741, openembedded#747)
WASAPI driver has been added (openembedded#754, thanks to @chirs241097)
General
Fix race condition in fluid_player_callback (openembedded#783, thanks to @arcln)
Improvements to LADSPA subsystem (openembedded#795, thanks to @mawe42)
[1] cazfi/meta-games#58
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 8, 2021
The only fallout by API/ABI changes in my world build was meta-games/scummvm.
Fix was sent [1]
fluidsynth 2.2.0
This release breaks ABI compatibility! Refer to the API docs for details.
A C++98 compliant compiler is now required to build fluidsynth (mailing list thread)
New features
Support loading SoundFonts >2GiB on Windows (openembedded#629)
Major overhaul of the sequencer and its event queue (openembedded#604)
Overlapping notes can be handled (openembedded#637)
Performance improvement, since the event queue no longer blocks the rendering thread
Time scale is not limited to 1000 anymore and can therefore be used for tempo changes
The following audio drivers have gained multi-channel support
DSound (openembedded#667, thanks to @jjceresa)
WaveOut (openembedded#667, thanks to @jjceresa)
The WinMIDI driver supports multiple devices (openembedded#677, thanks to @jjceresa)
Handle GS DT1 SysEx messages for setting whether a channel is used for rhythm part (openembedded#708, thanks to @chirs241097)
Support use of UTF-8 filenames under Windows (openembedded#718, thanks to @getraid-gg)
Improved support for overriding tempo of the MIDI player (openembedded#711, openembedded#713, thanks to @jjceresa)
Handle settings-related commands in user command file before initializing other objects (openembedded#739)
SoundFont loading has been parallelized (openembedded#746, openembedded#812, requires openMP)
The Oboe driver has gained a lower latency and other updates (openembedded#740, openembedded#741, openembedded#747)
WASAPI driver has been added (openembedded#754, thanks to @chirs241097)
General
Fix race condition in fluid_player_callback (openembedded#783, thanks to @arcln)
Improvements to LADSPA subsystem (openembedded#795, thanks to @mawe42)
[1] cazfi/meta-games#58
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 12, 2021
The only fallout by API/ABI changes in my world build was meta-games/scummvm.
Fix was sent [1]
fluidsynth 2.2.0
This release breaks ABI compatibility! Refer to the API docs for details.
A C++98 compliant compiler is now required to build fluidsynth (mailing list thread)
New features
Support loading SoundFonts >2GiB on Windows (openembedded#629)
Major overhaul of the sequencer and its event queue (openembedded#604)
Overlapping notes can be handled (openembedded#637)
Performance improvement, since the event queue no longer blocks the rendering thread
Time scale is not limited to 1000 anymore and can therefore be used for tempo changes
The following audio drivers have gained multi-channel support
DSound (openembedded#667, thanks to @jjceresa)
WaveOut (openembedded#667, thanks to @jjceresa)
The WinMIDI driver supports multiple devices (openembedded#677, thanks to @jjceresa)
Handle GS DT1 SysEx messages for setting whether a channel is used for rhythm part (openembedded#708, thanks to @chirs241097)
Support use of UTF-8 filenames under Windows (openembedded#718, thanks to @getraid-gg)
Improved support for overriding tempo of the MIDI player (openembedded#711, openembedded#713, thanks to @jjceresa)
Handle settings-related commands in user command file before initializing other objects (openembedded#739)
SoundFont loading has been parallelized (openembedded#746, openembedded#812, requires openMP)
The Oboe driver has gained a lower latency and other updates (openembedded#740, openembedded#741, openembedded#747)
WASAPI driver has been added (openembedded#754, thanks to @chirs241097)
General
Fix race condition in fluid_player_callback (openembedded#783, thanks to @arcln)
Improvements to LADSPA subsystem (openembedded#795, thanks to @mawe42)
[1] cazfi/meta-games#58
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Apr 13, 2021
The only fallout by API/ABI changes in my world build was meta-games/scummvm.
Fix was sent [1]
fluidsynth 2.2.0
This release breaks ABI compatibility! Refer to the API docs for details.
A C++98 compliant compiler is now required to build fluidsynth (mailing list thread)
New features
Support loading SoundFonts >2GiB on Windows (#629)
Major overhaul of the sequencer and its event queue (#604)
Overlapping notes can be handled (#637)
Performance improvement, since the event queue no longer blocks the rendering thread
Time scale is not limited to 1000 anymore and can therefore be used for tempo changes
The following audio drivers have gained multi-channel support
DSound (#667, thanks to @jjceresa)
WaveOut (#667, thanks to @jjceresa)
The WinMIDI driver supports multiple devices (#677, thanks to @jjceresa)
Handle GS DT1 SysEx messages for setting whether a channel is used for rhythm part (#708, thanks to @chirs241097)
Support use of UTF-8 filenames under Windows (#718, thanks to @getraid-gg)
Improved support for overriding tempo of the MIDI player (#711, #713, thanks to @jjceresa)
Handle settings-related commands in user command file before initializing other objects (#739)
SoundFont loading has been parallelized (#746, #812, requires openMP)
The Oboe driver has gained a lower latency and other updates (#740, #741, #747)
WASAPI driver has been added (#754, thanks to @chirs241097)
General
Fix race condition in fluid_player_callback (#783, thanks to @arcln)
Improvements to LADSPA subsystem (#795, thanks to @mawe42)
[1] cazfi/meta-games#58
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Apr 20, 2021
The only fallout by API/ABI changes in my world build was meta-games/scummvm.
Fix was sent [1]
fluidsynth 2.2.0
This release breaks ABI compatibility! Refer to the API docs for details.
A C++98 compliant compiler is now required to build fluidsynth (mailing list thread)
New features
Support loading SoundFonts >2GiB on Windows (#629)
Major overhaul of the sequencer and its event queue (#604)
Overlapping notes can be handled (#637)
Performance improvement, since the event queue no longer blocks the rendering thread
Time scale is not limited to 1000 anymore and can therefore be used for tempo changes
The following audio drivers have gained multi-channel support
DSound (#667, thanks to @jjceresa)
WaveOut (#667, thanks to @jjceresa)
The WinMIDI driver supports multiple devices (#677, thanks to @jjceresa)
Handle GS DT1 SysEx messages for setting whether a channel is used for rhythm part (#708, thanks to @chirs241097)
Support use of UTF-8 filenames under Windows (#718, thanks to @getraid-gg)
Improved support for overriding tempo of the MIDI player (#711, #713, thanks to @jjceresa)
Handle settings-related commands in user command file before initializing other objects (#739)
SoundFont loading has been parallelized (#746, #812, requires openMP)
The Oboe driver has gained a lower latency and other updates (#740, #741, #747)
WASAPI driver has been added (#754, thanks to @chirs241097)
General
Fix race condition in fluid_player_callback (#783, thanks to @arcln)
Improvements to LADSPA subsystem (#795, thanks to @mawe42)
[1] cazfi/meta-games#58
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit f186377)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fluidsynth 2.2.0 introduced API changes causing:
| audio/softsynth/fluidsynth.cpp:256:11: error: invalid conversion from 'long int ()(void)' to 'fluid_sfloader_callback_tell_t' {aka 'long long int (*)(void
The change should be compatible for version < 2.2.0 either
Signed-off-by: Andreas Müller schnitzeltony@gmail.com