Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases should be fully cross-versioned #6

Closed
lrytz opened this issue Dec 12, 2018 · 4 comments
Closed

Releases should be fully cross-versioned #6

lrytz opened this issue Dec 12, 2018 · 4 comments

Comments

@lrytz
Copy link

lrytz commented Dec 12, 2018

Unlike scala-library.jar, the scala compiler is not binary compatible between minor releases. Therefore, compiler plugins should be released with full cross versioning, and a new release is needed for every minor Scala release. See https://github.com/scalamacros/paradise/blob/2.12.8/build.sbt for example, https://search.maven.org/search?q=g:org.scalamacros.

@cb372
Copy link
Owner

cb372 commented Dec 12, 2018

Thanks, that's a good point.

I was taking my lead on this from kind-projector, which is not fully cross-versioned. Does that plugin need to be fixed in the same way? I assume it has simply "got lucky" so far and not run into any breaking changes in the compiler.

@lrytz
Copy link
Author

lrytz commented Dec 12, 2018

I'd say so, yes.. Let's get a confirmation from @adriaanm or @retronym :)

@adriaanm
Copy link

Yep, we don't check binary compatibility at all between even minor compiler releases. You could get lucky if you stick within the parts of the compiler that rarely change anymore, but I wouldn't recommend it.

@cb372
Copy link
Owner

cb372 commented Dec 13, 2018

Thanks for confirming. I'll switch to full cross-versioning and also open an issue on kind-projector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants