Add ability to use ShardedJedis for sharded caching with Redis #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the slow reply, I just got back from holiday. Thanks for the PR! I glanced through the code and it looks fine. I'll give it a proper review asap. |
| import scala.collection.JavaConversions.seqAsJavaList | ||
|
|
||
| val pool = new ShardedJedisPool(new JedisPoolConfig(), hosts.map { | ||
| case (host, port) ⇒ new JedisShardInfo(host, port) |
There was a problem hiding this comment.
No Unicode chars in the code please
|
Sorry, on closer inspection I've decided not to accept this PR in its current state because it duplicates a lot of code. But it's a useful feature and I'd like to accept it if you can refactor it a bit. Please let me know if any of my comments don't make sense, or if you need any help with refactoring. |
|
Thank you for the PR, but I ended up implementing this myself because I wanted to do some refactoring around Redis anyway. I've credited you in the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use consistent hashing when caching to multiple instances of Redis by using ShardedJedis.