-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scraper not fetching extra covers #431
Comments
This is an unfortunate necessity because of Comicvine's decision not to put the covers as fetchable via the API (something about deals with comic publishers). The way CVS used to do it was by scraping the web page. While this had technically been against the rules, Comicvine hadn't been checking for it until they changed their servers. They started blocking the IPs of people caught scraping their web pages. Search their API forum and you'll see a whole drama that unfolded within the last few months. Which is to say this will not be fixed until ComicVine changes their API to pass all of the covers along when requested. |
A work around to this at some point might be to add in the found books list On Fri, Feb 26, 2016 at 1:02 PM, boshuda notifications@github.com wrote:
|
I'm hoping that they actually add the alternate covers to their official API. They kinda suggested that they'd do it, but it hasn't happened yet. Once they do, it'll be really easy to get this feature working again. |
I know this is incredibly late in coming, but I thought I'd share that ComicVine does now, in fact, provide additional covers via the API. Not sure when it was added, but it definitely is there and works. All you need to do is update the _query_issue function in cvdb.py so that it looks in the DOM for the "associated_images" element and then append any image URLs to the issue.image_urls_sl list. This is such a useful feature and I'm just glad that it's working again. |
Thanks for noticing this, giotte! I implemented your changes into a new version of ComicVineScraper (1.0.102) and it seems to be working great. It'll be worth it for people to update to this new version, since it makes "find more covers" feature work properly again, and it will also improve the scraper's ability to "automatically" choose the correct comic book series when scraping (for people who have that feature turned on.) |
I don’t know why, but for some reason I cannot install the latest (final) update. The only thing it seems to write in the scripts folder is a few image files |
Try removing the plugin, restarting comicrack fully (or restart your entire computer), then reinstall the plugin. And then restart comicrack again if needed I seem to remember that there is a comicrack bug that interfered with installation of plugins sometimes. They was how people worked around it. |
WOW! Thanks, that did the trick |
After updating to 1.0.92 (ComicRack version 0.9.177), the scraper no longer finds any more covers, when I click "(more covers)". I'm simply told there's only a single cover.
A specific example would be Grimm Fairy Tales presents Red Riding Hood One-Shot (http://comicvine.gamespot.com/grimm-fairy-tales-presents-red-riding-hood-one-sho/4000-492312/). Zenescope never published anything in their life which only had one cover, which is what made me suspicious, and ComicVine obviously has more than one cover.
Let me know if you need any further information!
The text was updated successfully, but these errors were encountered: