-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pick up javafx-gradle-plugin fix for M1 architecture
Problem: until the recent release of JavaFX 17, it was impossible to run a JavaFX app on an M1 Mac without locally installing an early-access build of JavaFX SDK. Even after the release of JavaFX 17, however, it was still not possible to run a JavaFX application on an M1 Mac because of the bug reported at openjfx/javafx-gradle-plugin#112 (which caused led to the dreaded "No toolkit found" error). Solution: the PR at openjfx/javafx-gradle-plugin#113 fixes this error in the javafx-gradle-plugin, but has not yet been released. This commit assumes that the PR branch as been built and installed on the local machine, and expects to resolve it from the local maven cache. Happily, it works as expected, making it possible to run ./bisqfx without the SDK installed locally.
- Loading branch information
Showing
3 changed files
with
3 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,5 @@ | ||
javafxPluginVersion = 0.0.10 | ||
javafxPluginVersion = 0.0.11-SNAPSHOT | ||
gitVersionPluginVersion = 0.12.3 | ||
osPluginVersion = 1.7.0 | ||
runtimePluginVersion = 1.12.5 | ||
|
||
requiredJavaVersion = 16 | ||
javafxSdkProperty = bisq.javafx.sdk | ||
|
||
## Local JavaFX SDK path. Useful when early access builds are required that | ||
## cannot be resolved as normal dependencies by the gradle build. | ||
## | ||
## Do NOT uncomment this property here. Instead, copy it to your personal | ||
## ~/.gradle/gradle.properties file, uncomment and customize it there. | ||
## | ||
# bisq.javafx.sdk=/path/to/javafx-sdk | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters