Added use of proxy as set by env variable 'http_proxy' #308
Conversation
| @@ -425,6 +432,18 @@ private void downloadImpl(File file, String version) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| private Proxy getProxy() { | |||
| String http_proxy = System.getenv("http_proxy"); | |||
There was a problem hiding this comment.
Ah ok, so that's how you extract the proxy info, I was wondering what approach you picked.
I was thinking that information should be picked from ~/.config/kobalt/settings.xml to be consistent, but your approach is better than nothing for now.
There was a problem hiding this comment.
This variable should be called httpProxy by the way.
There was a problem hiding this comment.
This was only a first try in order to get something working. And sorry for the variable name. Do you want me to fix it?
|
That's fine, I'll fix it myself. Going to merge this, thanks! And sorry for all the trouble you had to go through to get this working, I appreciate your efforts :-) |
|
I did some reformatting and pushed. FYI I also renamed the environment variable to |
Not sure about log level in case of NumberFormatException for the port number.