Extracting out unrelated logic from TestNG class. #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved some of the parsing logic to the Parser class. * Moved some of the zip file parsing logic to its own class. * Added a test jar to support tests for Zip file extraction logic.
juherr
approved these changes
Nov 7, 2017
| suites.add(XmlSuiteUtils.newXmlSuiteUsing(classes)); | ||
| } | ||
| } catch (IOException ex) { | ||
| ex.printStackTrace(); |
| } | ||
| suites.add(suiteToAdd); | ||
| } | ||
| foundTestngXml = true; |
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class JarFileUtilsTest { | ||
| private static final File jar = new File("src/test/resources/testng-tests.jar"); |
There was a problem hiding this comment.
Note for later: the jar should/could be generated by the test (for example with https://github.com/shrinkwrap/shrinkwrap)
|
Yup, go right ahead @krmahadevan. I noticed @juherr hadn't looked yet so I didn't want to merge it just yet but it looked good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
own class.
extraction logic.
Fixes # .
Did you remember to?
CHANGES.txtWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.