Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missed cleavages from evidence.txt #104

Merged
merged 4 commits into from Jul 13, 2021
Merged

Conversation

pscheil
Copy link
Contributor

@pscheil pscheil commented Jul 10, 2021

missed cleavages metric can be computed from evidence.txt (for more recent versions of MaxQuant) if msms.txt is not provided

R/createReport.R Outdated Show resolved Hide resolved
R/createReport.R Outdated Show resolved Hide resolved
R/qcMetric_MSMS.R Outdated Show resolved Hide resolved
R/createReport.R Outdated
@@ -515,7 +516,7 @@ createReport = function(txt_folder = NULL, mztab_file = NULL, yaml_obj = list(),
lst_qcMetrics[["qcMetric_EVD_MissingValues"]]$setData(df_evd)

## trim down to the absolute required (we need to identify contaminants in MSMS.txt later on)
if (!DEBUG_PTXQC) df_evd = df_evd[, c("id", "contaminant")]
if (!DEBUG_PTXQC) df_evd = df_evd[, c("id", "contaminant", "fc.raw.file", "sequence", "missed.cleavages")]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, this will throw an error if missed.cleavages is missing.
However, if (!DEBUG_PTXQC) df_evd = df_evd[, names(df_evd) %in% c("id", "contaminant", "fc.raw.file", "sequence", "missed.cleavages")] should work.

Copy link
Owner

@cbielow cbielow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. Thanks!

@cbielow cbielow merged commit f69ce1a into cbielow:master Jul 13, 2021
@cbielow cbielow changed the title missed cleavage can also be created if present in evd and not in msms missed cleavages from evidence.txt Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants