Skip to content

Commit

Permalink
Set parentItem for pages in DockWindow
Browse files Browse the repository at this point in the history
After https://invent.kde.org/qt/qt/qtdeclarative/-/merge_requests/40 a
QQuickItem without a parentItem is always invisible. While this avoids
some crashes in plasmashell, it breaks some applications like MuseScore
where pages don't have a parent item.

This is also important for Qt6 porting.

Fixes musescore#17276
  • Loading branch information
easyteacher authored and cbjeukendrup committed Apr 19, 2023
1 parent 993b60f commit 0668726
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/appshell/view/dockwindow/dockwindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ void DockWindow::initDocks(DockPageView* page)
}

if (page) {
page->setParentItem(this);
page->init();
}

Expand Down

0 comments on commit 0668726

Please sign in to comment.