Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented the sexagesimal number parsing "feature" of YAML #11

Merged
merged 3 commits into from May 20, 2019
Merged

Documented the sexagesimal number parsing "feature" of YAML #11

merged 3 commits into from May 20, 2019

Conversation

Ocramius
Copy link
Contributor

@Ocramius Ocramius commented Feb 11, 2019 •
edited by cblp

@Ocramius
Corrected rq installation method
0184c9d 
Previous installation URI failed/offline: downloading files from distribution
s3 buckets instead. Also, this required new C++ deps that in turn led to a
newer base image requirement.
@Ocramius
Added date:time YAML SNAFU example: 12:34 is parsed as sexagesima…
2b17e37 
…l number in python

Ref: https://twitter.com/chrisbranch/status/1094581030147768320
Ref: https://docs.docker.com/v17.09/compose/compose-file/#ports
@Ocramius
Updated output as per newer dependencies/docker image
efffaba
@Jarzon Jarzon mentioned this pull request Feb 14, 2019
Closed
@Ocramius Ocramius mentioned this pull request Feb 21, 2019
Open
@Ocramius
Copy link
Contributor Author

@cblp could you glance over this one and/or merge it, if applicable?

@cblp
Copy link
Owner

cblp commented May 20, 2019

Oh, I'm sorry! Thank you for poking me! I'll view it asap.

cblp
cblp approved these changes May 20, 2019
View reviewed changes
Copy link
Owner

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@cblp cblp merged commit 99b61b5 into cblp:master May 20, 2019
@Ocramius Ocramius deleted the docs/sexagesimal-dumpster-fire branch May 20, 2019 19:49
@Ocramius
Copy link
Contributor Author

Thanks! No need to worry: happens all the time to me as well 👍

Jarzon added a commit to Jarzon/yaml-sucks that referenced this pull request May 25, 2019
@Jarzon
Merge pull request #1 from cblp/master
2cae6ab 
Documented the sexagesimal number parsing "feature" of YAML (cblp#11)
@Jarzon Jarzon mentioned this pull request Aug 14, 2019
Open
@alexjfisher
Copy link

It sucks harder when you get into longer sexagesimal parsing.

eg.

mac_address: 52:54:00:44:49:56

For a real world example, see https://tickets.puppetlabs.com/browse/PUP-9505
Some parsers see this as an Integer, (but not even the same Integer), and some a string. In ruby in particular, it depends on the version of ruby!

@Ocramius
Copy link
Contributor Author

@alexjfisher would you be able to send an example patch? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblp cblp cblp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ocramius @cblp @alexjfisher