fix of #1023 with changes from #1028 #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested importing symbols with sympy 1.9 and octave 5.2.0. |
cbm755
reviewed
Oct 16, 2021
| @@ -82,7 +82,8 @@ | |||
| 'import collections' | |||
| 'from re import split' | |||
| '# patch pretty printer, issue #952' | |||
| '_mypp = pretty.__globals__["PrettyPrinter"]' | |||
| 'from sympy.printing.pretty.pretty import PrettyPrinter' | |||
| '_mypp = PrettyPrinter' | |||
There was a problem hiding this comment.
Awesome I was just looking at this. For older sympy maybe we need to keep the old form? I haven't figured out the earlier sympy where this works....
There was a problem hiding this comment.
Seems to work on sympy 1.6. I think I will just do a try: except: and fall back on the old way, until we have our CI up and running again
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One year no changes, then two PR just 20 minutes apart ;-) I've seen #1028 was just a little faster. I put this one in, nevertheless, as it contains the fix for the argument reverse of #952 which also seems to be broken.