Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subs: use make_matrix_or_array and use 2-d indexing #1227

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

cbm755
Copy link
Collaborator

@cbm755 cbm755 commented Sep 3, 2022

Fixes Issue #1226. Related to Issue #1222.

This makes test @sym/and, or, etc pass.

Base automatically changed from uniop to Array_not_Matrix September 6, 2022 00:22
Copy link
Collaborator

@alexvong243f alexvong243f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems. Perhaps it's possible to simplify things a bit in @sym/subs but I don't know how to do it right now.

Anyway, the

syms x
e = (x == 3) & (x^2 == 9)
subs(e, x, [-3 0 3])

test case passes, so it's good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants