This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Update QueryForm to handle username/email-based sharing #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also includes the relevant clean method and an update to the save method for notifying users when a query is shared with them. Tests for these methds are also included.
3 tasks
| # then give up since we only support email and username | ||
| # lookups. | ||
| try: | ||
| user = User.objects.get(username=label) |
There was a problem hiding this comment.
A tad more optimal.. User.objects.only('email').get(username=label)
bruth
added a commit
that referenced
this pull request
Aug 15, 2013
Update QueryForm to handle username/email-based sharing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds necessary fields and methods to QueryForm to enable username/email based sharing of Query models. This pull requests also includes tests to completely cover the QueryForm save() and clean_usernames_or_emails() methods. Additionally, the clean_json() has been appropriately split into clean_context_json() and clean_view json() to match the actual field names. clean_json() was useless.