This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Add signal to support additional foreign keys on Sample #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| from django.dispatch import Signal | |||
|
|
|||
| pre_delete_sample = Signal(providing_args=["pk_set", "cursor"]) | |||
There was a problem hiding this comment.
Change strings to use single quotes to be consistent with the rest of the codebase.
| @@ -111,6 +113,9 @@ def handle(self, *args, **options): | |||
| ''', [project_id]) | |||
|
|
|||
| # Remove samples | |||
| pre_delete_sample.send(sender=Project, | |||
There was a problem hiding this comment.
If this is going to use the pre_delete_sample signal then the pk_set argument should be the sample IDs in the project being deleted. If you are going to send the project ID then change this to use a new pre_delete_project signal.
|
Please squash this into a single commit |
| @@ -111,6 +113,9 @@ def handle(self, *args, **options): | |||
| ''', [project_id]) | |||
|
|
|||
| # Remove samples | |||
There was a problem hiding this comment.
Reorder these lines:
pre_delete_project.send(
sender=Project, pk=project_id, cursor=cursor)
# Remove samples
cursor.execute('''
DELETE FROM sample WHERE project_id = %s
''', [project_id])
awenocur
force-pushed
the
add-signal
branch
2 times, most recently
from
7129ef8
to
cabfd72
Compare
| @@ -70,6 +71,8 @@ def handle(self, *args, **options): | |||
| '''.format(columns), valid_ids) | |||
|
|
|||
| # Remove sample | |||
Signed-off-by: Adam Wenocur <wenocur@email.chop.edu>
naegelyd
added a commit
that referenced
this pull request
Aug 25, 2014
Add signal to support additional foreign keys on Sample
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the delete-sample command to be extended, to support models with foreign keys pointing to Sample.