This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Add support for result/variant sets #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
The local_settings.py.sample file and README has been updated to reflect this change. Projects can import the settings and extend where needed. Signed-off-by: Byron Ruth <b@devel.io>
This reverts commit e425d0d. Signed-off-by: Byron Ruth <b@devel.io>
key_map was deprecated in django-preserialize and has been renamed to aliases. Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
The base classes limit the samples to what the requesting user is authorized to view based on the projects they are associated with. In addition, resource links have been updated to include the host. Signed-off-by: Byron Ruth <b@devel.io>
The dialog lists samples available to the user in a table which is sortable and can be filtered. Clicking a row will select the sample which then can be saved. Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
The sample dialog is initialized and available at `cilantro.dialogs.sample`. The notifyRequired handler has been replaced to open the sample dialog. Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
This has the effect in Cilantro that it will not be displayed in the list of available query concepts. The sample dialog is the new method for selecting a sample. Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
Remove unnecessary whitespace Signed-off-by: Byron Ruth <b@devel.io>
The previous lookup was using DataField fields. The migration now uses the name field of the DataConcept to find the sample concept(s) Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Both of these issues were caused by bad checks caused by using === in place of == when comparing undefined to null. The more generic truthiness test is now used instead of specifically checking against something using ===. Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
Signed-off-by: Don Naegely <naegelyd@gmail.com>
|
|
||
| supported_content_types = ( | ||
| 'application/json', | ||
| 'multipart/form-data',) |
There was a problem hiding this comment.
Move right paren to next line.
| diagnoses[key].omim_id + '" target="_blank">' + // jshint ignore: line | ||
| diagnoses[key].name + '</a>'); | ||
|
|
||
| if ((priority = diagnoses[key].priority)) { |
There was a problem hiding this comment.
This assignment isn't necessary.
|
Let's promise ourselves to not have anymore large PRs like this in the future. Very difficult to discern how changes are affecting everything else. |
|
I agree. This one got out of control given all the PRs that were merged On Thu, Aug 14, 2014 at 9:41 PM, Byron Ruth notifications@github.com
Best Regards, Donald Naegely |
This also supressess unnecessary logging statements Signed-off-by: Don Naegely <naegelyd@gmail.com>
bruth
added a commit
that referenced
this pull request
Aug 15, 2014
Add support for result/variant sets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes models, resources, and pages for interacting with result sets. Any additional changes or features can be requested in new issues and revisions can be made against master.