Feature/Manage views and URLs #126

tomivm · 2024-03-31T05:28:10Z

In this PR the different cases and views are handled.

To create a 'new board' the view is:

To edit the new board the view is: (this board is saved on the store as a stash

To open a saved boards by ID

Close #120

following the owner of the library comment: amannn/next-intl#406 (comment)

…oard-url

maxicapodacqua

Approving this as we are close to the deadline, make sure we re-work this solution as some parts of the code are become harder to read, and it's using interface instead of types

RodriSanchez1 · 2024-04-01T14:23:41Z

src/app/[locale]/dashboard/[id]/@savedData/TabsSelector.tsx

+import History from '../history/History';
+import { useShallow } from 'zustand/react/shallow';
+
+interface TabPanelProps {


Change to type instead

RodriSanchez1 · 2024-04-01T14:46:29Z

src/components/IntlWrapperForAsync/IntlWrapperForAsync.tsx

+import { NextIntlClientProvider, useMessages } from 'next-intl';
+import pick from 'lodash.pick';
+
+export default function IntlWrapperForAsync({


We can change the function name to IntlAsyncComponentProvider

tomivm added 30 commits March 20, 2024 12:49

Create component to allow use NextIntlClientProvider on async components

12c9d9a

following the owner of the library comment: amannn/next-intl#406 (comment)

Make board page an async component implementing the IntlWrapperForAsync

b74f3d9

create a loading.tsx to @board

10b9f58

remove wrong semicolon

0b65a73

Create stuff to stash a Dashboard

eafcb04

Create constants for the STASHED_CONTENT_ID dashboard params

f25a061

Stash Dashboard on rehydration if it Id is equal to STASHED_CONTENT_ID

0a01da3

useSetInitialBoardHook on client Board Container

148093f

PreventFetch of Initial board if route is equal to STASHED_CONTENT_ID

b8d6dba

stash board on create

cf5c1c6

Replace change board Action by Change Dashboard

149e34a

change dashboard on board creation

a6e2ffc

Replace the use of changeBoard by changeDashboard

6610c19

detect changes on dashboard Id in dashboard page

51a1c51

Convert the SavedData component to a pararel route

52b438e

move special files to the SavedData component

71dd44a

Merge remote-tracking branch 'origin/main' into feature/capture-dashb…

2d4e22b

…oard-url

require id's to be string

a391be3

replace parallel routes for SavedData components

3645349

Merge branch 'main' into feature/capture-dashboard-url

73f5d35

split useSetInitialBoard in 2 useEffect

d7e8f42

improve 'useSetDashboardIdOnChange'

163bd1d

Create a hook to handle the Dashboard ID change on @savedData component

a11bc70

Create a state to await hydration

f7b49b7

remove unnecessary prop types for the dashboard

18d41e7

preventUseSetBoardOnDashboardIdChange when saved Board edit click

3a1266d

use a single ref to prevent useSetBoardOnDashboardIdChange

da08f36

Create Action to set board and prompt drom dashboard slice

3602d7e

Improve hook to set Dashboard on dashboard Id change

64ed56a

Manage error on fetch initial board

8db380d

tomivm added 8 commits March 27, 2024 00:12

improve saved Board ids pm fake db

436469d

Merge branch 'main' into feature/capture-dashboard-url

b7331de

set initial content from dashboard Id

41d0664

Prevent create a board from a different path than 'create'

1c997d0

improve logic to set the stashedBoard on direct navigation to new path

4de1e5c

Implement an accordion for the prompt form UX UI

8dab3e8

Navigate to initial content on 'New Board' Click

93e51e3

Add Hover to 'new board' on Accordion

e74721c

tomivm added the enhancement New feature or request label Mar 31, 2024

tomivm requested review from maxicapodacqua and RodriSanchez1 March 31, 2024 05:28

tomivm self-assigned this Mar 31, 2024

maxicapodacqua approved these changes Apr 1, 2024

View reviewed changes

tomivm added 2 commits April 1, 2024 09:18

merge branch main

b9cf866

Clean prompt before set 'create' view

b333183

RodriSanchez1 reviewed Apr 1, 2024

View reviewed changes

RodriSanchez1 approved these changes Apr 1, 2024

View reviewed changes

This was referenced Apr 1, 2024

Change interface to type #128

Open

Change the function name to IntlAsyncComponentProvider #129

Open

RodriSanchez1 merged commit 9becaef into main Apr 1, 2024
1 check passed

RodriSanchez1 deleted the feature/capture-dashboard-url branch April 1, 2024 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/Manage views and URLs #126

Feature/Manage views and URLs #126

tomivm commented Mar 31, 2024 •

edited

Loading

maxicapodacqua left a comment

RodriSanchez1 Apr 1, 2024

RodriSanchez1 Apr 1, 2024

Feature/Manage views and URLs #126

Feature/Manage views and URLs #126

Conversation

tomivm commented Mar 31, 2024 • edited Loading

maxicapodacqua left a comment

Choose a reason for hiding this comment

RodriSanchez1 Apr 1, 2024

Choose a reason for hiding this comment

RodriSanchez1 Apr 1, 2024

Choose a reason for hiding this comment

tomivm commented Mar 31, 2024 •

edited

Loading