Feature - add loading spinner on upload image #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshkumar1019
changed the title
RodriSanchez1
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Hi! @rakeshkumar1019 Thank for your contribution! Your work is well! But the spinner will be not displayed when the app is proccesing the image. The inItial change of the loading state needs to be under the InputImage.component.js. Let me know if you need a further explanation 🙌
|
@RodriSanchez1 let me know if this can be merged |
RodriSanchez1
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR new loading spinner is added on
TileEditor.component. It will be displayed when the image is loading.Spinner is used from progress MUI v4
see this screenshot for the reference.
close #1614