Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new user communicator on changeDefaultBoard #1686

Conversation

RodriSanchez1
Copy link
Collaborator

close #1679

@RodriSanchez1 RodriSanchez1 self-assigned this May 10, 2024
@RodriSanchez1 RodriSanchez1 changed the title Create new communicator for user on changeDefaultBoard Create new user communicator on changeDefaultBoard May 10, 2024
Copy link
Collaborator

@tomivm tomivm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Create a more General solution to use this in the future. Remove unnecessary boilerplate from the ' changeDefaultBoard' function

@RodriSanchez1 RodriSanchez1 added this to the 1.34.0 milestone May 17, 2024
@RodriSanchez1 RodriSanchez1 requested a review from tomivm May 17, 2024 19:12
@tomivm
Copy link
Collaborator

tomivm commented May 19, 2024

I will clean the milestone for this PR to avoid the duplication of titles on the milestone list

@tomivm tomivm removed this from the 1.34.0 milestone May 19, 2024
@RodriSanchez1 RodriSanchez1 requested a review from tomivm May 20, 2024 19:10
@RodriSanchez1 RodriSanchez1 merged commit 68ff9ca into cboard-org:master May 27, 2024
5 checks passed
@RodriSanchez1 RodriSanchez1 deleted the fix/createUserCommunicatorOnChangeDefaultBoard branch May 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary communicators are created on the db whe updateApiCommunicator is used
2 participants