Editorial changes and fixes for Thomas Fossati's ARTART review #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henkbirkholz
approved these changes
Oct 10, 2023
Comment on lines
+97
to
+110
| start: ~Etime / null | ||
| end: ~Etime / null | ||
| ? duration: ~Duration / null | ||
| ]) | ||
|
|
||
|
|
||
| clumsy-Period = #6.1003([ | ||
| (start: ~Time, | ||
| ((end: ~Time, | ||
| (start: ~Etime, | ||
| ((end: ~Etime, | ||
| ? duration: null) // | ||
| (end: null, | ||
| duration: ~Duration))) // | ||
| (start: null, | ||
| end: ~Time, | ||
| end: ~Etime, |
Comment on lines
+212
to
+216
| Superscript notation denotes exponentiation. For example, 2 to the | ||
| power of 64 is notated: 2<sup>64</sup>. In the plain-text rendition | ||
| of this specification, superscript notation is not available and | ||
| exponentiation therefore is rendered by the surrogate notation seen | ||
| here in the plain-text rendition. |
| @@ -329,14 +332,15 @@ etime-detailed = ({ | |||
| * (uint .feature "etime-critical-extension") => any | |||
| }) .within etime-framework | |||
| ~~~ | |||
|
|
|||
| {: #tag-1001 title="CDDL definition of Tag 1001"} | |||
| @@ -309,7 +312,7 @@ This document does not define supplementary text keys. | |||
| A number of both unsigned and negative-integer keys are defined in | |||
| the following subsections. | |||
|
|
|||
| A formal definition of Tag 1001 in CDDL is: | |||
| {{tag-1001}} provides a formal definition of Tag 1001 in CDDL. | |||
| It does define how to use these representations with the extended | ||
| time format.) | ||
| additional map keys for the map that is the content of the tag (see | ||
| `etime-detailed` in {{tag-1001}}), |
Comment on lines
+258
to
+259
| of natural platform time formats. Some platforms use epoch-based | ||
| time formats that require some computation to convert them into the |
There was a problem hiding this comment.
Non-blocking nit:
Suggested change
| of natural platform time formats. Some platforms use epoch-based | |
| time formats that require some computation to convert them into the | |
| of natural platform time formats. Some platforms use epoch-based | |
| time formats that require computation to convert them into the |
There was a problem hiding this comment.
I actually like the qualification as to what amount of computation is needed (i.e., not much).
| The time value indicated by the value under this key can be further | ||
| Key 1 indicates a base time value that is exactly like the data item that would | ||
| be tagged by CBOR tag 1 (POSIX time {{TIME_T}} as int or float). | ||
| As described above, the time value indicated by the value under this |
| Keys 4 and 5 indicate a base time value and are like key 1, except that the data item is an array as | ||
| defined for CBOR tag 4 or 5, respectively. | ||
| This can be used to include a Decimal or Bigfloat epoch-based float | ||
| {{TIME_T}} in an extended time, e.g., to achieve higher resolution or to |
| @@ -447,7 +454,7 @@ used to determine the point in time. | |||
|
|
|||
| The first three are analogous to `clock-quality-grouping` in | |||
| {{RFC8575}}, which is in turn based on the definitions in | |||
| {{IEEE1588-2008}}; two more are specific to this document. | |||
| {{IEEE1588-2008}}; the last two are specific to this document. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!