Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial clarifications from Qin Wu's iotdir review #21

Merged
merged 9 commits into from Oct 19, 2023

Conversation

cabo
Copy link
Contributor

@cabo cabo commented Oct 18, 2023

No description provided.

henkbirkholz and others added 7 commits October 19, 2023 13:01
Co-authored-by: Henk Birkholz <henkbirkholz@users.noreply.github.com>
Co-authored-by: Carsten Bormann <cabo@users.noreply.github.com>
...(negative integer as key), or one of base time or
critical (unsigned integer as key).
@@ -244,7 +244,8 @@ beyond the original tags 0 and 1 (defined in {{Sections 3.4.1 and 3.4.2 of -cbor

By incorporating a way to transport {{IXDTF}} suffix information ({{tzh}},
{{suff}}), additional indications can be provided of intents about the
interpretation of the time given, in particular for future times.
interpretation of the time given, in particular also for instances of
time that, at the time they are being described, are in the future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

10<sup>-3</sup> seconds (milliseconds) could be expressed by one of
the extended time tags in {{uncertainty-example}} (note the slight
rounding error in the third case, which is probably inconsequential
for an uncertainty value):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very happy with that

For the unsigned integers as keys, the choice of base time or critical
needs to be indicated in the brief semantics description.
(Elective map keys may be explicitly marked as such in the
description, e.g., to distinguish them from critical keys.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@henkbirkholz henkbirkholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@cabo cabo merged commit b9866a2 into master Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants