[BUG] Linuxisms in fsearch 0.1 #297
Comments
|
Thanks for letting me know! I'll fix those, but I'm going to add some compile time checks to detect the current platform. Because I want to keep those features on Linux builds. The fact that However in the meantime you're of course free to just replace all usages of
Can you post the error message when you invoke |
|
Actually, I did deal with the Here is the output for ./autogen.sh and ./configure |
|
Updating the patch from 0.1beta4 takes care of the |
That's great! Regarding the configure.ac issue, that's because the |
|
Yes, the I added the meson PortGroup. However, now I need to patch This leaves the malloc issue: |
|
@Schamschula, both the I'm going to release 0.1.1 in the next days with those fixes and a couple others as well. |
It's a glibc thing, actually. I've fixed this back in 2017 when I added fsearch to FreeBSD Ports Collection and filed #63 but it didn't get traction, unfortunately. The patches are still there. |
Not necessarily. I haven't tried to prove this formally, but my quick tests showed that tmp1 = g_utf8_collate_key_for_filename(s1, -1);
tmp2 = g_utf8_collate_key_for_filename(s2, -1);
ret = strcmp(tmp1, tmp2);
g_free(tmp1);
g_free(tmp2);
return ret;should DTRT. |
|
@danfe: The problem with using a different sort algorithm is this: The entries in the database have a certain order, so when we change the sort algorithm and FSearch reads the old database, which was sorted with the old algorithm, you get inconsistent behavior. For example binary searching won't work anymore, because the file arrays are not sorted by our new compare function. Or using the column header to sort the results will lead to inconsistent sort order. By default all results are sorted according to their order in the database file, but when a user clicks on a column, FSearch might need to resort at runtime. |
Oh, I see, yeah, that's a bummer. :-(
Right, this part was quite clear. Not sure what's the elegant solution to this, maybe implementing some sort of versioning in the database? |
The database already has some basic versioning. I just want to avoid bumping the database version too often. But yeah, the next version bump will probably happen with the 0.2 release anyway, because there are also some other changes planned for the database format and then I can safely change the sort algorithm. |
|
|
I compiled a local build, but when I start it, it isn't connecting to my XQuartz server. |
|
UPDATE: I got it to work, but the magnifying glass is weird, and it only works through SSH. |
|
What magnifying glass do you mean? |
|
Maybe it changed, but the logo on an empty search looks weird.
…On Mon, Oct 4, 2021, 7:14 AM Christian Boxdörfer ***@***.***> wrote:
What magnifying glass do you mean?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#297 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALXWUYBJ7WSFEO6JWWWUUXTUFGEA3ANCNFSM5E5MPJGA>
.
|
|
For some reason, noq it fails with |
How this and the following discussion are related to the subject of the issue, if I may ask? :-/ |
|
It may be that fsearch is expecting something from Linux, but can't find it on a MacOS system. |
Yeah, it would be nice not to use any GNU or other system-specific extensions. Meanwhile, I've replaced the slow |
|
I finally got back to getting search to build under MacPorts It required a couple more tweaks: macports/macports-ports@1d6be4c |
Describe the bug
When attempting to build fsearch 0.1 under MacPorts I get several errors in fsearch_database.c.
To Reproduce
Steps to reproduce the behavior:
When building
Expected behavior
Successful build (as for previous tag 0.1beta4)
Screenshots
w/o malloc patch
fsearch_database.c:28:10: fatal error: 'malloc.h' file not found
#include <malloc.h>
^~~~~~~~~~
CC fsearch-fsearch_database_view.o
with malloc and AT_NO_AUTOMOUNT patch
Undefined symbols for architecture x86_64:
"_malloc_trim", referenced from:
_db_free in fsearch-fsearch_database.o
"_strverscmp", referenced from:
_db_entry_compare_entries_by_path in fsearch-fsearch_database_entry.o
_sort_entry_by_path_recursive in fsearch-fsearch_database_entry.o
_db_entry_compare_entries_by_name in fsearch-fsearch_database_entry.o
_db_entry_compare_entries_by_extension in fsearch-fsearch_database_entry.o
Desktop (please complete the following information):
localectl status: non-existent under macOSAdditional context
Notes:
PS: There is an issue with configure.ac
even though I have configured the Portfile to use
compiler.cxx_standard 2011The text was updated successfully, but these errors were encountered: