Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap to scroll does not work #233

Closed
minaMagedNaeem opened this issue Mar 11, 2019 · 3 comments
Closed

Tap to scroll does not work #233

minaMagedNaeem opened this issue Mar 11, 2019 · 3 comments

Comments

@minaMagedNaeem
Copy link

Usage Details

  • Language: Swift
  • Platform: iPhone

Expected Behavior

When enabling tap to scroll property, the label should start scrolling when tapped and stopped when tapped

Actual Behavior

The label does not scroll when tapped

@minaMagedNaeem
Copy link
Author

I figured out that this block prevents it from scrolling

if !tapToScroll && !holdScrolling && shouldBeginScroll {
beginScroll(sequence)
}

@daviddelmonte
Copy link

daviddelmonte commented Mar 17, 2019

I'm seeing this issue as well. Anyone have a workaround?

@cbpowell
Copy link
Owner

Good catch, thanks! Looks like some of the logic had gotten mixed up, as you pointed out. Release 3.2.1 fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants