Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggerScrollStart() so that it can properly ignore prevention conditions #289

Merged
merged 1 commit into from Jul 18, 2023

Conversation

yujinakayama
Copy link
Contributor

The documentation comment for triggerScrollStart() describes:

Overrides any non-size condition which is preventing the receiver from automatically scrolling, and begins a scroll animation.
Currently the only non-size conditions which can prevent a label from scrolling are the tapToScroll and holdScrolling properties.

Overrides any non-size condition which is preventing the receiver from automatically scrolling, and begins a scroll animation.
Currently the only non-size conditions which can prevent a label from scrolling are the `tapToScroll` and `holdScrolling` properties. This

However, invoking triggerScrollStart() on a label with holdScrolling = true does not trigger scroll.
This PR fixes the issue by calling updateAndScroll() with overrideHold: true option.

@cbpowell
Copy link
Owner

Thanks for pointing this out! I'll take a look this afternoon and get it merged shortly.

@cbpowell cbpowell merged commit eb89273 into cbpowell:master Jul 18, 2023
@yujinakayama yujinakayama deleted the fix-triggerScrollStart branch July 18, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants