Allow unsafe legacy renegotiation on HTTPS #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js 18 supports OpenSSL 3.0 which requires secure renegotiation by default. Since the units use self-signed cert without publicly available CA, the requests sent to the units need to be sent using HTTPS Agent with SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION.
|
@cbrandlehner could you please take a look at this PR? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // the units use a self-signed cert and the CA doesn't seem to be publicly available. | ||
| // Node.js 18 supports OpenSSL 3.0 which requires secure renegotiation by default. | ||
| const unsafeAgent = new https.Agent({ | ||
| rejectUnauthorized: false, |
Check failure
Code scanning / CodeQL
Disabling certificate validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 18 supports OpenSSL 3.0 which requires secure renegotiation by default. Since the units use self-signed cert without publicly available CA, the requests sent to the units need to be sent using HTTPS Agent with SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION.
Fixes #279
Fixes #277.