String trim fix for missing final character #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the off-by-one error reported by ununnilium in the forum. The final character of model and the final character of serial number were being deleted. For instance, Model: WDC WD30EFRX-68EUZN0 Serial Number: WD-WMC4N0H2JLJP should become WDC_WD30EFRX-68EUZN0-WD-WMC4N0H2JLJP not WDC_WD30EFRX-68EUZN-WD-WMC4N0H2JLJ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the off-by-one error reported by ununnilium in the forum.
The final character of model and the final character of serial number
were being deleted. For instance,
Model: WDC WD30EFRX-68EUZN0
Serial Number: WD-WMC4N0H2JLJP
should become WDC_WD30EFRX-68EUZN0-WD-WMC4N0H2JLJP not
WDC_WD30EFRX-68EUZN-WD-WMC4N0H2JLJ.