Skip to content

Commit

Permalink
fix(@cubejs-core): stricter enforcement for DateRange type in TimeDim…
Browse files Browse the repository at this point in the history
…ensions cube-js#1621
  • Loading branch information
cbroome committed Dec 17, 2020
1 parent caa676d commit 5547eca
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/cubejs-client-core/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -680,18 +680,20 @@ declare module '@cubejs-client/core' {

export type TimeDimensionGranularity = 'second' | 'minute' | 'hour' | 'day' | 'week' | 'month' | 'year';

export type DateRange = string | [string, string];

export type TimeDimensionBase = {
dimension: string;
granularity?: TimeDimensionGranularity;
};

export type TimeDimensionComparison = TimeDimensionBase & {
compareDateRange: Array<string | Array<string>>;
compareDateRange: Array<DateRange>;
dateRange?: never;
};

export type TimeDimensionRanged = TimeDimensionBase & {
dateRange?: string | string[];
dateRange?: DateRange;
};

export type TimeDimension = TimeDimensionComparison | TimeDimensionRanged;
Expand Down

0 comments on commit 5547eca

Please sign in to comment.