Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keyboard shortcuts and prompt for search engines. #1

Closed
wants to merge 1 commit into from

Conversation

githubms
Copy link

Also, changed from e.key to e.which (former wasn't working well for me in Safari.)

cbrst added a commit that referenced this pull request Jun 10, 2015
@cbrst cbrst closed this Jun 10, 2015
@cbrst
Copy link
Owner

cbrst commented Jun 10, 2015

Dammit, now I know why you changed the keybinding for Google 😞

@githubms
Copy link
Author

Sorry about that. You can change that back I think. Hope the changes are useful. Thanks for the pull!

@cbrst
Copy link
Owner

cbrst commented Jun 10, 2015

Oh, I didn't pull the index, just the JS. That's why I noticed the g is interfering with sg. But there's really nothing I can do about that, except for changing the binding.

@githubms
Copy link
Author

I believe it should still work with g for google. It allows multi char key bindings and clears keys pressed after couple seconds. You just cannot have multi key binding which starts with g or some other single char that's already taken.

On Jun 10, 2015, at 11:06 AM, Christian Brassat notifications@github.com wrote:

Oh, I didn't pull the index, just the JS. That's why I noticed the g is interfering with sg. But there's really nothing I can do about that, except for changing the binding.


Reply to this email directly or view it on GitHub.

@cbrst
Copy link
Owner

cbrst commented Jun 10, 2015

Nah, once you hit g, it goes to Google instead of opening the prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants