-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamically loaded images #73
Comments
Currently JavaScript is executed after the static document is inlined. I.E. dynamic images are loaded too late in the process for the inlining to happen. Todo:
|
Not sure whether there's a quick solution. However the code should be cleaned up for 1.0 as far as possible. |
Not going to be supported for now |
Perhaps this could be reopened once the following are fixed: whatwg/htlm #421 - Iframes should inherit the base URL of the parent document in some cases |
The parent's base URL is only fitting if the page you are trying to render is the same URL. I feel the real problem is that currently the inlining of resources happens before the JS is run, rather than the other way around. The choice to run the JS in an iframe outside of the base URL context was made because otherwise the iframe onload event would not trigger if the URL was not from the same origin, and rasterizehtml would never receive a callback, waiting for ever. There might also have been other reasons involved, but I currently cannot reproduce. |
Images loaded in JS with relative paths with different basePath to host document will fail. This is due to the page content being extracted and executed in an iframe without the document's base url.
The text was updated successfully, but these errors were encountered: